Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-firebase-cloud-messaging example setup code #10686

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Fix with-firebase-cloud-messaging example setup code #10686

merged 1 commit into from
Mar 20, 2020

Conversation

aviaryan
Copy link
Contributor

This PR updates the FCM setup code which should fix the issue #10628. This change is needed after firebase v7.0.0 because of a breaking change.

Official docs don't reflect this as of this moment. More details here. firebase/quickstart-js#422

@ijjk
Copy link
Member

ijjk commented Feb 25, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
buildDuration 9.4s 9.7s ⚠️ +366ms
nodeModulesSize 56.2 MB 56.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
index.html gzip 924 B 924 B ✓
link.html gzip 934 B 934 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
buildDuration 10s 11.2s ⚠️ +1.3s
nodeModulesSize 56.2 MB 56.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
main-HASH.js gzip 5.05 kB 5.05 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..b61f.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.2 kB 57.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
main-HASH.module.js gzip 4.14 kB 4.14 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
_app.js gzip 1.06 kB 1.06 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
_app.module.js gzip 577 B 577 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.26 kB 5.26 kB ✓
Client Build Manifests
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary aviaryan/next.js fix-fcm-example Change
_error.js gzip 290 kB 289 kB -415 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 289 kB 290 kB ⚠️ +572 B
link.js gzip 298 kB 298 kB -46 B
routerDirect.js gzip 298 kB 296 kB -1.59 kB
withRouter.js gzip 296 kB 298 kB ⚠️ +1.29 kB
Overall change 1.47 MB 1.47 MB -186 B

Commit: 4985e3f

@aviaryan aviaryan mentioned this pull request Feb 25, 2020
Closed
@aviaryan aviaryan changed the title update FCM setup code, fixes #10628 Fix with-firebase-cloud-messaing example setup code Feb 25, 2020
@aviaryan aviaryan changed the title Fix with-firebase-cloud-messaing example setup code Fix with-firebase-cloud-messaging example setup code Feb 25, 2020
@aviaryan
Copy link
Contributor Author

Update on this - firebase/quickstart-js#422 has been merged by the Firebase team which confirms this is the correct approach.

What do I need to do to get this PR ready for merge?

@timneutkens timneutkens merged commit 920bf76 into vercel:canary Mar 20, 2020
@timneutkens
Copy link
Member

Thanks!

This was referenced Apr 13, 2020
Merged
Closed
This was referenced Apr 22, 2020
Merged
Closed
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviaryan @ijjk @timneutkens